Narrow protobuf dependency to exclude protobuf >= 4 #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop-gap until the generated code can be updated with a newer
version of protoc, as required by the protobuf 4.x release.
Description
protobuf
4.x requires that the generated files be generated with a newer version of protoc than has been used.This is a historical breakage (i.e. affects previously released versions), so this is a simple fix that could be trivially backported to previous releases if desired.
Part of open-telemetry/opentelemetry-python#2717 (No corresponding bug lodged here)
The failure is visible in CI run for #1108 though.
Type of change
How Has This Been Tested?
Pip Test
In a clean venv, with opentelementy-python main at .\open-telemetry-python, and this branch at \opentelemetry-python-contrib:
passes.
WIth this PR, it fails:
Note that right now, this test must explicitly specify
protobuf>4
because the protobuf 4.x release package has been yanked, so it's no longer selected by default. Had this not been done, the test for this PR would have successfully installed, but chosen an earlier version of protobuf.Does This PR Require a Core Repo Change?
There's a matching PR at open-telemetry/opentelemetry-python#2720 though.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.